Skip to content

Conversation

@iddoh-jfrog
Copy link
Contributor

@iddoh-jfrog iddoh-jfrog commented Jan 26, 2026

  • The pull request is targeting the dev branch.
  • The code has been validated to compile successfully by running go vet ./....
  • The code has been formatted properly using go fmt ./....
  • All static analysis checks passed.
  • All tests have passed. If this feature is not already covered by the tests, new tests have been added.
  • Updated the Contributing page / ReadMe page / CI Workflow files if needed.
  • All changes are detailed at the description. if not already covered at JFrog Documentation, new documentation have been added.

Add local sast server command

@attiasas attiasas added ignore for release Automatically generated release notes safe to test Approve running integration tests on a pull request labels Jan 28, 2026
@github-actions github-actions bot removed the safe to test Approve running integration tests on a pull request label Jan 28, 2026
@github-actions
Copy link

👍 Frogbot scanned this pull request and did not find any new security issues.


Copy link
Contributor

@attiasas attiasas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice job! Take a look at my comments, in addition:

  1. Please add a bit more description to the PR about this command
  2. After AM is released with the new cmd, make sure tests are passing

@@ -0,0 +1,15 @@
package sast_server
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets make sure technical writer goes over the text and approved by PM

Enrich = "sbom-enrich"
UploadCdx = "upload-cdx"
MaliciousScan = "malicious-scan"
SastServer = "sast-server"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

assign flag to command at commandFlags in the file

return err
}

port := c.GetStringFlagValue("port")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
port := c.GetStringFlagValue("port")
port := c.GetStringFlagValue(flags.Port)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ignore for release Automatically generated release notes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants