fix: wait before opening the browser#1526
Open
tim-goto wants to merge 1 commit intojfrog:masterfrom
Open
Conversation
Contributor
Author
|
@RemiBou thanks for reviewing my other PRs, would you mind taking a look at this one too? |
Contributor
Author
|
Hey @RemiBou would you mind reviewing again? Thanks! |
Contributor
|
@tim-goto we took it internally and we dont want to change existing behaviour |
Contributor
Author
|
Hey @RemiBou that is sad to hear, would you mind explaining your reasoning? E.g. the github cli does exactly the same thing and since I only use one monitor, I always have to switch back to the console window when using the jfrog cli to actually see the code that I have to enter. |
Contributor
Author
|
I could also add a flag and only wait for input if that flag is set, would that be something that you would merge? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
it is a bit annoying that the browser opens immediately after the server selection without giving you time to read the code beforehand. @naveenku-jfrog can you also please take a look here? Our TSM is Douglas Hemsworth. Thanks!