Skip to content

disco: re-enable secret sending by default #787

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SgtCoDFish wants to merge 1 commit into
base: master
Choose a base branch
from
Open

disco: re-enable secret sending by default #787

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deploy/charts/disco-agent/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,10 +348,10 @@ This description will be associated with the data that the agent uploads to the
#### **config.sendSecretValues** ~ `bool`
> Default value:
> ```yaml
> false
> true
> ```

Enable sending of Secret values to CyberArk in addition to metadata. Metadata is always sent, but the actual values of Secrets are not sent by default. When enabled, Secret data is encrypted using envelope encryption using a key managed by CyberArk, fetched from the Discovery and Context service. This value will default to "true" in a future release when further updates have been made to the Discovery and Context backend.
Enable sending of Secret values to CyberArk in addition to metadata. Metadata is always sent, but the actual values of Secrets are not sent by default. When enabled, Secret data is encrypted using envelope encryption using a key managed by CyberArk, fetched from the Discovery and Context service.
#### **authentication.secretName** ~ `string`
> Default value:
> ```yaml
Expand Down
3 changes: 1 addition & 2 deletions deploy/charts/disco-agent/templates/NOTES.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -9,6 +9,5 @@ APP VERSION: {{ .Chart.AppVersion }}
> kubectl logs -n {{ .Release.Namespace }} -l app.kubernetes.io/instance={{ .Release.Name }}

{{ if .Values.config.sendSecretValues }}
WARNING: sendSecretValues is not finalised and is subject to breaking changes in the future.
It should be enabled only for testing and validation.
NB: sendSecretValues is set to "true". Encrypted secret data will be sent to the CyberArk Discovery and Context service
{{ end }}
4 changes: 2 additions & 2 deletions deploy/charts/disco-agent/values.schema.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -166,8 +166,8 @@
"type": "string"
},
"helm-values.config.sendSecretValues": {
"default": false,
"description": "Enable sending of Secret values to CyberArk in addition to metadata. Metadata is always sent, but the actual values of Secrets are not sent by default. When enabled, Secret data is encrypted using envelope encryption using a key managed by CyberArk, fetched from the Discovery and Context service. This value will default to \"true\" in a future release when further updates have been made to the Discovery and Context backend.",
"default": true,
"description": "Enable sending of Secret values to CyberArk in addition to metadata. Metadata is always sent, but the actual values of Secrets are not sent by default. When enabled, Secret data is encrypted using envelope encryption using a key managed by CyberArk, fetched from the Discovery and Context service.",
"type": "boolean"
},
"helm-values.extraArgs": {
Expand Down
4 changes: 1 addition & 3 deletions deploy/charts/disco-agent/values.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -200,9 +200,7 @@ config:
# Metadata is always sent, but the actual values of Secrets are not sent by default.
# When enabled, Secret data is encrypted using envelope encryption using
# a key managed by CyberArk, fetched from the Discovery and Context service.
# This value will default to "true" in a future release when further updates have been
# made to the Discovery and Context backend.
sendSecretValues: false
sendSecretValues: true

authentication:
secretName: agent-credentials
Expand Down
Loading