Add regexp support for view filters#5430
Open
piyooshm wants to merge 1 commit intojesseduffield:masterfrom
Open
Add regexp support for view filters#5430piyooshm wants to merge 1 commit intojesseduffield:masterfrom
piyooshm wants to merge 1 commit intojesseduffield:masterfrom
Conversation
Allow filtering with a Go regexp when gui.filterMode is regexp, or in substring/fuzzy mode by prefixing the filter with gui.regexpFilterPrefix (default re:). Invalid patterns match nothing; case rules match substring filters ((?i) when the pattern has no uppercase letter). Add gui.regexpFilterPrefix so the prefix is configurable. Document in Config.md and Searching.md, update the JSON schema, and add unit and integration tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Allow filtering with a Go regexp when gui.filterMode is regexp, or in substring/fuzzy mode by prefixing the filter with gui.regexpFilterPrefix (default re:). Invalid patterns match nothing; case rules match substring filters ((?i) when the pattern has no uppercase letter).
Add gui.regexpFilterPrefix so the prefix is configurable. Document in Config.md and Searching.md, update the JSON schema, and add unit and integration tests.
Please check if the PR fulfills these requirements
go generate ./...)Closes #5429