Repository navigation
HLS audio pairing, opaque sticker warning, DTS support in Info - #29
Merged
Merged
Conversation
… groups Mediabunny's primary audio track already prefers one that pairs with the primary video. Two places did not keep that preference. When the primary could not be decoded, the fallback took the first decodable track in list order; and the audio menu offered every track in the stream. In an HLS stream whose variants each have their own audio group, both could pick audio belonging to a different variant from the picture on screen. The fallback now tries tracks that pair with the video first, and the menu lists only those (all of them, in an ordinary file, where everything pairs). On a test stream where the 640x360 video pairs with English and German and the 320x180 one with French, listed first: with English undecodable the old fallback chose French, which does not pair; the new one chooses German. The menu shows English and German. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
A clip picked as a sticker that cannot carry alpha sits on the video as a solid rectangle, which looks like a fault in the cut-out. The decoder now asks Mediabunny's canBeTransparent(), which reads the file's own flags (Matroska's alpha mode, ProRes 4444) without decoding anything, and the player says so, pointing at Remove Background. Checked: a transparent VP9 WebM gives no message; the same picture with alpha discarded, and the smoke fixture, do. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The Info menu asked canDecode() without first loading the on-demand DTS and TrueHD decoders, so opened before the file had played, it reported audio the player decodes as unsupported. It now loads them first. Measured on a DTS file: canDecode() as the menu asked it was false, and true once loaded; the real Info menu, opened before any playback, now shows "Supported". Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The smaller items from the MediaBunny audit, each in its own commit.
HLS audio stays with the picture
Opaque video stickers say so
canBeTransparent()reads the file's flags without decoding, and the player shows a message pointing at Remove Background.DTS / TrueHD in the Info menu
Not done
A global "formats this browser can play" list (
getDecodableCodecs). The Info menu already says, for each file, whether it can be decoded here, so the list would add little.Testing
The build succeeds, and smoke, sticker, source-failure and
test:tracksall pass.🤖 Generated with Claude Code