Fix duplicate cross-class form detections - #37
Draft
JasBogans wants to merge 1 commit into
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Problem
FFDNet currently uses Ultralytics' default class-aware NMS. When the same region
is detected as different field classes, such as a text field and a choice
button, the detections cannot suppress one another and can produce stacked
duplicate PDF fields.
Change
Pass
agnostic_nms=Trueto the default FFDNet prediction call so stronglyoverlapping detections compete regardless of predicted class. The fast ONNX
path is unchanged.
Validation
pytest -q: 8 passedruff check tests/inference_test.py: passedThe five existing Ruff findings in
commonforms/inference.pyare unchanged bythis PR.
AI assistance disclosure
This change was developed with AI assistance. All changes were reviewed and
validated by the submitter using the test suite.