feat(cacheable): support tag invalidation in getOrSet#1688
Open
laesse wants to merge 1 commit into
Open
Conversation
Add tags to GetOrSetFunctionOptions and forward them to set when a value is computed on a cache miss. Add regression coverage and update the documentation with tag-based getOrSet usage.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds support for tag-based invalidation in the getOrSet method of Cacheable. It updates the GetOrSetFunctionOptions type to include an optional tags array, passes these tags to the underlying set operation during a cache miss, updates the README and JSDoc documentation, and adds corresponding unit tests to verify the behavior. I have no feedback to provide.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add tags to GetOrSetFunctionOptions and forward them to set when a value is computed on a cache miss. Add regression coverage and update the documentation with tag-based getOrSet usage.
Please check if the PR fulfills these requirements
What kind of change does this PR introduce?
feature