Repository navigation
fix(sqlite): wrap PRAGMA failure as RuntimeException, sharpen lazy-connection tests - #26
Merged
Merged
Conversation
…nnection tests - SqLite::createPdoConnection wraps a PDOException from the PRAGMAs in a RuntimeException (previous preserved), the handle stays reset; same error form as PdoConnection::createPdoConnection and the documented contract. - LazyConnectionTest: remove the tautological COUNT()+1 assertion; rename the healthy-handle pool test to what it checks and add a test that really runs the pool health check's reconnect branch (explicit disconnect); add a test for the PRAGMA failure (non-database file). - Skill adapter-dbconnection: document the PRAGMA failure form. Paket-Pendant: PdoConnection-Fehlerform (src/Connection/PdoConnection.php) — kein neues Konstrukt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Review fixes A3/A4/A7 of v1.4.0. Zielversion: v1.4.1