Skip to content

examples: block & async - #3

Closed
peter-lyons-kehl wants to merge 2 commits into
japaric:masterfrom
peter-lyons-kehl:master
Closed

peter-lyons-kehl wants to merge 2 commits into
japaric:masterfrom
peter-lyons-kehl:master

Conversation

@peter-lyons-kehl

Copy link
Copy Markdown

hi Jorge @japaric,
Thank you for panic-never.

  • panic-never is better than any other way of verifying that there's no panic.
  • Surprise: panic-never also works for async. Would you like to add these examples for it?
  • Also, this shows how to make it link (at least on Linux) using .cargo/config.toml.
  • And (on Linux) I've made the non-panicking examples exit/return using a syscall (with asm).
  • Side note: I do see your https://github.com/japaric/syscall.rs (and that the original GitHub repo doesn't exist anymore, and the whole crate was yanked on crates.io). I understand that it's difficult ti maintain the syscall crate/repo, and that you (or any one person) don't have resources to test it on so many architectures... So, I do not ask to use syscall for exit. I believe supporting the exit on Linux only (using asm) is enough, and it keeps it simple. (Whoever doesn't run Linux/WSL/docker can easily run it on GitHub Actions and similar.)

@peter-lyons-kehl

Copy link
Copy Markdown
Author

hi Jorge @japaric,
please ignore this PR. As per OpenDevicePartnership/cga#7, all async code has an implicit panic...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant