AGENTS.md follow-up: apply the #3785 review points that did not land - #3912
Open
mcfnord wants to merge 6 commits into
Open
AGENTS.md follow-up: apply the #3785 review points that did not land#3912mcfnord wants to merge 6 commits into
mcfnord wants to merge 6 commits into
Conversation
"Always" tells an agent to attach evidence and to disclose what it did not verify, but not what to do with a claim it cannot test. One line closes that, names the hedge words as the detectable symptom, and extends the rule to code comments, docs and commit messages. docs/agents/COMMENTING.md opened with the same rule scoped to posting; with the general form in the always-loaded file, that bullet keeps only its posting half. CHANGELOG: SKIP Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The Build line offers a CONFIG+=headless serveronly build; the Testing line
then connects a client. That binary rejects -c:
$ ./Jamulus -n -c localhost
./Jamulus: Client only option(s) '--connect' used. See '--help' for help
(exit 1; built from 11a28d5)
One clause closes the contradiction.
CHANGELOG: SKIP
Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Retired message IDs are kept reserved in src/protocol.h (seven OLD entries, one marked 'needed for compatibility to old servers >= 3.4.6 and <= 3.5.12') rather than reclaimed — the invariant an agent breaks while cleaning up unused enums. Stated as one Never Do bullet. CHANGELOG: SKIP Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Jamulus.pro (clang_format target), coding-style-check.yml, and .clang-format-ignore each carry a comment telling the editor to update the other two; none of the three is a file an agent reads before it bites. One Style bullet surfaces it. CHANGELOG: SKIP Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
'One logical change per PR' and 'smallest change' are line 5, bold, above the fold; 'Builds? Tested?' are the Testing and Always lines. This file is prepended to every prompt, so each repeat costs context on every call. 'See CONTRIBUTING.md' stays in Read when relevant, where it carries a when-to-read note. CHANGELOG: SKIP Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
The last bullet was the fragment 'Disclose AI-generated text' — no form, no example, while AGENTS.md carries the complete rule. Give it the form and point at the canonical statement. CHANGELOG: SKIP Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 AI: Follow-up to #3785, on the invitation there. Six one-line changes; each traces to a point raised in that review, each stands alone, and any can be dropped if it fails the stable-and-general bar. Cost, measured:
AGENTS.md651 → 740 words.Short description of changes
AGENTS.md:CONFIG+=headless serveronlybinary rejects the Testing line's client — built from11a28d57and run:./Jamulus -n -c localhost→Client only option(s) '--connect' used. See '--help' for help, exit 1. One clause closes the contradiction (raised in review, pljones preferring the plain build).PROTMESSID_*or alter an existing message layout — retired IDs stay reserved asOLDinsrc/protocol.h, exactly the invariant an agent breaks while tidying "unused" enums.Jamulus.pro's ownclang_formatnote documents: a new source directory or file extension needsCLANG_FORMAT_SOURCES,coding-style-check.ymland.clang-format-ignoreupdated together, or localmake clang_formatand CI check different files.docs/agents/COMMENTING.md: the first bullet keeps only its posting-specific half, deferring the general test-or-cut rule to the always-loaded file; the last bullet was the fragment "Disclose AI-generated text" and now carries the form.CHANGELOG: SKIP
Context: Fixes an issue?
Follow-up to #3785.
Does this change need documentation? What needs to be documented and how?
No — it is documentation.
Status of this Pull Request
Ready for review. One commit per change, so any line is droppable in isolation.
What is missing until this pull request can be merged?
Maintainer judgment on which lines clear the "stable and general" bar.
Checklist
serveronlybinary rejects-c) was built and run; output above. No code is changed.🤖 This message was written by AI and reviewed by @mcfnord.