FreeBSD fix for dual-stack and IPv6 QoS#3664
Open
softins wants to merge 2 commits intojamulussoftware:mainfrom
Open
FreeBSD fix for dual-stack and IPv6 QoS#3664softins wants to merge 2 commits intojamulussoftware:mainfrom
softins wants to merge 2 commits intojamulussoftware:mainfrom
Conversation
Member
|
Ok. Will need to test this on macOS myself then. |
ann0see
reviewed
Apr 30, 2026
|
|
||
| #if defined( Q_OS_DARWIN ) | ||
| // sendto_ipv4_with_tos - helper function for macOS to set TOS when sending IPv4 over IPv6 socket | ||
| #if defined( Q_OS_BSD4 ) |
Member
There was a problem hiding this comment.
And this is guaranteed to always hold for macOS too?
Member
Author
There was a problem hiding this comment.
Yes, in the header file, Q_OS_DARWIN and Q_OS_BSD4 are set on consecutive lines for Apple.
And my successful tests on Mac confirmed it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of changes
Enhances #3622 to fix an issue with running on FreeBSD, which is subtly different from macOS.
CHANGELOG: FreeBSD: make -6 option work properly with both IPv6 and IPv4 peers.
Context: Fixes an issue?
Fixes #3478 and also a crash with #3622 when running with -6 on FreeBSD
Does this change need documentation? What needs to be documented and how?
No, bug fix only
Status of this Pull Request
Tested on both macOS and FreeBSD. No changes to Linux or Windows.
What is missing until this pull request can be merged?
Nothing, but it is important to get this into 3.12.0
Checklist