Add documentation and refactor macOS signing workflow #3624
+26
−19
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ann0see
commented
Feb 7, 2026
| MACOS_CERTIFICATE: ${{ secrets.MACOS_CERT }} # Base64 encoded Developer ID Application certificate. See https://help.apple.com/xcode/mac/current/#/dev154b28f09 | ||
| MACOS_CERTIFICATE_PWD: ${{ secrets.MACOS_CERT_PWD }} # Password protecting secrets.MACOS_CERTIFICATE | ||
| MACOS_CERTIFICATE_ID: ${{ secrets.MACOS_CERT_ID }} # Certificate ID of secrets.MACOS_CERTIFICATE. If unknown, import secrets.MACOS_CERT into keychain and get the hash via "security find-identity -v" | ||
| MACOS_CERTIFICATE_DEV_ID_APPLICATION: ${{ secrets.MACOS_CERT }} # Base64 encoded Developer ID Application certificate. See https://help.apple.com/xcode/mac/current/#/dev154b28f09 |
Member
Author
There was a problem hiding this comment.
In the next step, the GitHub secret variables should be renamed. Not in this PR yet as it touches multiple repos.
ann0see
commented
Feb 7, 2026
| env: | ||
| ## Creating certificates | ||
| # Generate the certificates from Xcode. You can Manage Certificates in Apple Accounts settings or the Apple Developer account page. | ||
| # In Xcode Settings: Right click on Developer ID Application, Mac App Distribution (does not exist, maybe also developer id application??) and Mac Installer Distribution certificates. |
Member
Author
There was a problem hiding this comment.
Suggested change
| # In Xcode Settings: Right click on Developer ID Application, Mac App Distribution (does not exist, maybe also developer id application??) and Mac Installer Distribution certificates. | |
| # In Xcode Settings: Right click on Developer ID Application, Mac App Distribution and Mac Installer Distribution certificates. |
Here, I haven't figured out yet what the appstore .pkg creating certificate is called.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Short description of changes
Refactors the singing workflow and adds documentation
CHANGELOG: SKIP
Context: Fixes an issue?
Related to: #3600
Does this change need documentation? What needs to be documented and how?
This is documentation
Status of this Pull Request
Formatting needed potentially. Works on jamulussign repo: https://github.com/ann0see/jamulussign/releases/tag/r3_12_0betasign
What is missing until this pull request can be merged?
Formatting (potentially)
Checklist