Skip to content

Close remaining BusyBox notice review#44

Merged
jacklv-coder merged 1 commit into
mainfrom
codex/rootfs-busybox-remaining-notices
Jul 27, 2026
Merged

Close remaining BusyBox notice review#44
jacklv-coder merged 1 commit into
mainfrom
codex/rootfs-busybox-remaining-notices

Conversation

@jacklv-coder

Copy link
Copy Markdown
Owner

Summary

Close the remaining BusyBox candidate-material license and attribution review as one coherent change.

  • reconstruct the exact BusyBox source state by applying all 33 pinned Alpine aports patches and the pinned configuration
  • derive the 487-unit dry-run build graph and its 562-file recursive local-include closure
  • pin and review 41 additional source files that retain independent third-party terms, provenance, copyright, or redistribution notices
  • increase BusyBox evidence from 19 to 60 files, initial candidates from 37 to 78, and reviewed external payloads from 97 to 138
  • mark BusyBox candidate-material engineering coverage complete, leaving four other source origins with package-specific work
  • keep complete NOTICE, legal review, corresponding-source, and redistribution gates closed

The audit excludes TLS-only sources because the pinned Alpine wget HTTPS patch leaves CONFIG_TLS disabled. Of the 41 selected files, only libbb/hash_md5_sha.c and shell/ash.c are touched by the fixed patch set; the five relevant patch payloads are separately pinned and do not remove or rewrite the relied-on notices.

Validation

  • pre-push codex review --uncommitted: no findings
  • ./Scripts/check-docs.sh
  • compliance generator reproducibility check against the pinned RootFS archive
  • SHA256SUMS verification
  • 138-file reviewed notice bundle verification
  • all Ruby compliance test suites
  • RootFS candidate smoke manifest tests
  • runtime smoke script tests
  • ./Scripts/test.sh: 139 tests, 0 failures, 1 expected environment-only skip
  • pinned RootFS archive integration test: 1/1 passed
  • git diff --check

@jacklv-coder

Copy link
Copy Markdown
Owner Author

@codex review

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Hooray!

Reviewed commit: a06effd8b4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

@jacklv-coder
jacklv-coder merged commit cc4609b into main Jul 27, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant