HOST-010: bind deterministic package evidence#45
Conversation
|
Independent read-only CR record
This comment records the advisory result only. The Claude CLI did not author this comment, approve the PR, or perform any GitHub mutation. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: f660411b0a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| for excluded in &package.exclusions { | ||
| if !is_safe_relative_path(&excluded.path) | ||
| || !excluded.path.starts_with(&format!("{}/", source.app_root)) | ||
| || previous.is_some_and(|path: &str| excluded.path.as_str() <= path) |
There was a problem hiding this comment.
Validate exclusion reasons against their paths
A device_free_package manifest can currently claim that any safe, app-root-relative path was excluded as mas_receipt or sc_info, including a confirmed binary path, because this loop checks only path safety, prefix, and ordering and never examines excluded.reason or conflicts with binaries. As a result, oprobe verify accepts contradictory package evidence such as an exclusion for Payload/App.app/App labeled sc_info; enforce that each reason matches its exact reserved path component (and reject paths still represented as output code) before accepting the manifest.
Useful? React with 👍 / 👎.
Closes #43
Summary
Local verification
Scope
This PR does not add IPA input to the CLI, publish an IPA, access a device, modify Mach-O, decrypt bytes, prove plaintext, validate signatures, sign, install, or make a compatibility claim.