Skip to content

Ogre deprecation j3o format - Example#2726

Open
NwosuTy wants to merge 5 commits intojMonkeyEngine:masterfrom
NwosuTy:Ogre-Deprecation-J3o-Format
Open

Ogre deprecation j3o format - Example#2726
NwosuTy wants to merge 5 commits intojMonkeyEngine:masterfrom
NwosuTy:Ogre-Deprecation-J3o-Format

Conversation

@NwosuTy
Copy link
Copy Markdown

@NwosuTy NwosuTy commented Apr 29, 2026

Tagged The Ogre Loader as Deprecated

Converted all Models and Scenes used in Examples to .j3o files, and then switched all deprecated ogre files loading paths to the new .j3o files except where specified needed for ogre loading testing, deleted all unused ogre files

Note: could not find the main.scene file for conversion in scenes such as the TestAspectFov, TestMultiplesFilters etc

NwosuTy added 3 commits April 29, 2026 18:05
Marked Ogre Loaders with Deprecated Tag

Converted all Ogre files except where neccessary to .J3o file and modified where used in examples to load .j3o file itself,  also deleted unused Ogre files
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates various asset loading paths in the jMonkeyEngine examples to use the .j3o format instead of the deprecated OgreXML (.mesh.xml, .scene) formats. Additionally, it adds deprecation notices and annotations to the Ogre-related classes and packages to encourage migration to modern formats like glTF. I have no further feedback to provide.

@NwosuTy
Copy link
Copy Markdown
Author

NwosuTy commented Apr 30, 2026

@riccardobl I know where the problem is and would fix and send, in the mean time the main.scene/j3o file I asked of is throwing bull errors in some scenes I was asking for its location but it seems that's fine for you

@riccardobl
Copy link
Copy Markdown
Member

riccardobl commented Apr 30, 2026

The main.scene is loaded from a zip file via http, you can see the code here:

assetManager.registerLocator(
"https://storage.googleapis.com/google-code-archive-downloads/v2/code.google.com/jmonkeyengine/wildhouse.zip",
HttpZipLocator.class);
} else {

that's from the very old jme repo on google code, if you want to convert it, I can rehost it somewhere else, but not an hard requirement for this PR as it is going to be a bit painful to debug

Restored Elephant.Skeleton.xml file for the Core tests, needed a mes.xml file with an anim composer

Modified screenshottests files to load the .j3o files rather than the previously changed ogre files
@github-actions
Copy link
Copy Markdown

🖼️ Screenshot tests have failed.

The purpose of these tests is to ensure that changes introduced in this PR don't break visual features. They are visual unit tests.

📄 Where to find the report:

⚠️ If you didn't expect to change anything visual:
Fix your changes so the screenshot tests pass.

If you did mean to change things:
Review the replacement images in jme3-screenshot-tests/build/changed-images to make sure they really are improvements and then replace and commit the replacement images at jme3-screenshot-tests/src/test/resources.

If you are creating entirely new tests:
Find the new images in jme3-screenshot-tests/build/changed-images and commit the new images at jme3-screenshot-tests/src/test/resources.

Note; it is very important that the committed reference images are created on the build pipeline, locally created images are not reliable. Similarly tests will fail locally but you can look at the report to check they are "visually similar".

See https://github.com/jMonkeyEngine/jmonkeyengine/blob/master/jme3-screenshot-tests/README.md for more information

Contact @richardTingle (aka richtea) for guidance if required

Could Have Sworn i committed these files, restored them to fix null errors and failing screenshot tests
@NwosuTy NwosuTy changed the title Ogre deprecation j3o format Ogre deprecation j3o format - Example Apr 30, 2026
@NwosuTy
Copy link
Copy Markdown
Author

NwosuTy commented Apr 30, 2026

@riccardobl i am done, you could proceed with a manual test, thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants