build: migrate dev tooling from make + tox to just#139
Merged
Conversation
RUF067 fires on every top-level statement because the whole public API intentionally lives in inject/__init__.py, so it is turned off project-wide rather than per file. ISC004 caught a real bug: a stray trailing comma made the runtime binding error message a one-element tuple instead of a string, so the raised exception showed the tuple instead of the text. Dropping the comma restores the intended message. D420 reorders the get_injector_or_die docstring so Returns comes before Raises. RUF075 wraps the yields in the test context-manager fixtures in try/finally so their cleanup still runs when the caller raises. The now-unused `# noqa: RUF029` on the async fixtures is dropped too; that removal is a ruff auto-fix.
Owner
|
Cool, thanks. Should I make the next release? |
Contributor
Author
|
It's up to you of course 😃 However, the most recent work is actually only dev tooling + imo very minor bug fixing. There's one thing: the README now mentions 5.5.0 for Python 3.10 but 5.5.0 has not been released yet. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again,
Replace
make+toxwith a singlejusttask runner, plus the lint and CI cleanups that come with it.Migrate to
justReplace tox and the Makefile with a
Justfilewith the full task list (format, lint, type-check, test matrix across 3.10-3.14), and make CI use those recipes.Why
justand not a Makefile?justis a command runner, not a build system, so it avoids Make's build-target stuff: recipes aren't file targets, there's no.PHONY, and we can pass arguments. See the just manual. There's a section with the advantages over make.Running
justin a terminal outputs:Ruff fixes
Fix a real ISC004 bug (a stray comma made a runtime-binding error message a tuple), reorder a docstring (D420), make the test context-manager fixtures exception-safe (RUF075), and disable RUF067 for the single-module layout.
CI runners
Run every job on
ubuntu-latest.Full mypy re-enabled
Add the full-tree mypy back as its own blocking job, split from the green public-API check.
Note
The
Type checking (library code)job is red: it surfaces 17 pre-existing mypy errors instead of hiding them. Every other job is green.Thank you and all the best 😄
Elias