Drop Python 3.9#137
Merged
Merged
Conversation
Owner
|
Hi!
Sure.
5.5.0 is better.
Yes.
Yes, of course.
OK. |
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi again!
Python 3.9 is end of life now, so I think it is a good time to drop it. Python 3.9 is not compatible with all latest versions of our dev-dependencies.
I made three small commits so it is easy to read: drop 3.9, remove some dead config, and add the missing tox env for 3.14.
One thing to check: CHANGES and the README assume 5.5.0 but it is your call if you prefer 6.0.0.
I also have a question: Would you be okay with using uv and adding a uv.lock file? You seemed open to it in #119. The main benefit is that we can pin the dev tools. Right now ruff is not pinned, and we run it with all rules plus preview. So every new ruff release can add errors and break CI for no real reason. With a lock file we could update ruff when we want.
If you like the idea, I can prepare a draft so you can see how it looks. I would also be happy to clean up the code a bit over time, and maybe try a newer type checker like pyrefly or ty later.
No problem if you do not want to.
Best
Elias