-
Notifications
You must be signed in to change notification settings - Fork 43
chore: use only crates.io #25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
Just pinging on this here again -- no worries if you don't want to use this, but would still be interested in collaborating on this type of tooling! |
Yes, I'd like to publish this, but the git-specific dependencies aren't preventing me from doing so. It's mostly just that I've been busy recently and haven't viewed it as a super high priority to get working as people can just use
Could you run the benchmarks I've set up in this repo to see what the performance effect of these changes are? You just need to:
I personally feel like current main feels regularly too slow for me, so I'm worried about merging any changes that disable the changes I've made to improve performance as-is.
I'd love to use a rust-native library for this, but unfortunately I can't find any that fits my needs. As far as I can tell, If you know of a rust-native library (or even a library that seems less difficult to work with from rust) that has support for rendering to images, I'd be happy to check it out for usage here. I just haven't found one yet. |
|
I'd be interested in being able to compile install it from cargo for packaging purposes.. |
|
@Autoparallel Are you working on a version with lopdf ? |
|
@Kreijstal I haven't started yet, but I'd be keen to since it would fit excellently with my current project! |
|
@itsjunetime Thank you for your response! I'll give those benchmarks a shot soon. Haven't looked into Rust-native PDF renderers yet -- wasn't sure if |
Notes
You mention in #10 that you want to do a release of this crate, which would be great! I also read through some of the issues you have which led you to pin to other versions of
ratatuiandratatui-image.If we can get beyond that, then this could be published to crates.io instead (which would definitely be preferred by many).
Running with these changes on my machine, I can't notice any poor performance, but there may be some issues with resizing my terminal. Using iTerm2 on MacOS.
Tasks
rattyandratatui-imageDiscussion
I came about this because I've been building learner as a means to have a nice database for research. Part of it can be seen as a replacement for things like Zotero, and I just set up a TUI with it and was hoping to use a TUI based PDF reader -- so I found this!
I'm curious if you'd also be interested in using
lopdfinstead ofpopplers-rs? This would be all Rust native and not have FFI topopplersbindings and I think would help this be more universally compatible.I'm really happy to see this and help push it along! Let me know what I can do.