Make scroll move screen when zoomed in #126
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxdexh
force-pushed
the
more-zoom
branch
2 times, most recently
from
9522c98 to
f5e25ab
Compare
itsjunetime
approved these changes
Dec 5, 2025
Owner
itsjunetime
left a comment
itsjunetime
left a comment
There was a problem hiding this comment.
Yeah, nice - 1 small annoying nit but it looks nice :)
Collaborator
Author
|
I did some testing and found that the behavior felt incomplete because it was missing "hold shift to scroll horizontally", so I implemented that. In the process, I also cleaned up the code by pulling out all logic relating to scrolling into a capture, and introducing a simple Also all zoom checks now use a consistent |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes it so that scrolling moves the camera instead of changing the page, if zooming is available and applicable (i.e. on kitty in fill-screen mode).
I also took the liberty of moving the logic modifying fields of
Zoomto inherent impls to make it easier to change the internals of zoom. Also I accidentally left in the zoom cap for ctrl scroll in my last PR, which shouldn't happen again this way.I also increased the step size for panning to make it feel less sluggish.