Repository navigation
Add --init flag allowing users to scaffold the toml - #27
Merged
Merged
Conversation
Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>
itowlson
requested changes
Oct 1, 2026
itowlson
left a comment
Owner
There was a problem hiding this comment.
Ooh! This looks great! The one change I'd like is to unify your new pluginify manifest struct with the existing pluginify manifest struct. The existing struct is PackagingSettings and it will need to be made Serialise but I think it's worth it. (But if there's a compelling reason to split them then I'm fine with being talked around!)
(The other comment is me musing on restructuring some parts of the CLI and doesn'r require immediate action.)
Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds a new
--initflag. It allows users to scaffold thespin-pluginify.toml.If present, user must specify
--nameand--packageas well:Help docs for
--nameand--packageare grouped underInit Options: