Skip to content

Add --init flag allowing users to scaffold the toml - #27

Merged
itowlson merged 2 commits into
itowlson:mainfrom
thorstenhans:feat/init
Oct 1, 2026
Merged

itowlson merged 2 commits into
itowlson:mainfrom
thorstenhans:feat/init

Conversation

@thorstenhans

Copy link
Copy Markdown
Contributor

This PR adds a new --init flag. It allows users to scaffold the spin-pluginify.toml.

If present, user must specify --name and --package as well:

spin pluginify --init --name <PLUGIN-NAME> --package <./PATH/TO/EXECUTABLE>

Help docs for --name and --package are grouped under Init Options:

Init Options:
  -n, --name <NAME>        The name of the plugin (requires --init)
  -p, --package <PACKAGE>  Path to the plugin executable (requires --init)

Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>

@itowlson itowlson left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ooh! This looks great! The one change I'd like is to unify your new pluginify manifest struct with the existing pluginify manifest struct. The existing struct is PackagingSettings and it will need to be made Serialise but I think it's worth it. (But if there's a compelling reason to split them then I'm fine with being talked around!)

(The other comment is me musing on restructuring some parts of the CLI and doesn'r require immediate action.)

Comment thread src/main.rs
Comment thread src/main.rs Outdated
Signed-off-by: Thorsten Hans <thorsten.hans@gmail.com>

@itowlson itowlson left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Brilliant, thanks Thorsten!

@itowlson
itowlson merged commit abdce67 into itowlson:main Oct 1, 2026
6 checks passed
@thorstenhans
thorstenhans deleted the feat/init branch October 1, 2026 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants