ci: run the Code Review workflow via docker compose (drop Task) - #41
Merged
Conversation
Standardise the pr.yaml jobs on `docker compose` directly instead of Task, and harden against composer's dist-download rate limit, adapted from event-database-imports #98. - Cache vendor/ (actions/cache@v5, keyed on composer.lock) and pre-pull images (docker compose pull --quiet) in both jobs. - Replace `task site:update` with explicit up --wait + composer install; `task fixtures:load:test` with an inline index loop; `task api:test:coverage` and `task code-analysis:phpstan` with direct `docker compose exec` calls. The Taskfile targets remain for local development; only CI stops using them.
|
✅ No changes detected in API specification |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## develop #41 +/- ##
==========================================
Coverage 71.89% 71.89%
Complexity 226 226
==========================================
Files 29 29
Lines 637 637
==========================================
Hits 458 458
Misses 179 179
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
…ker-compose # Conflicts: # CHANGELOG.md
…ker-compose # Conflicts: # .github/workflows/pr.yaml # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Standardise
pr.yamlondocker composedirectly instead of Task, and harden against composer's dist-download rate limit — adapted from event-database-imports #98 (itself from os2display).Changes (
pr.yaml, both jobs)actions/cache@v5onvendor/, keyed oncomposer.lockwith avendor-php8.4-restore-key. On a hitcomposer installdoes no dist downloads (no HTTP 429); on a miss the restore-key pre-populates most ofvendor/.docker compose pull --quietup front.go-task/setup-task;task site:update→docker compose up --detach --wait+composer install;task fixtures:load:test→ an inline index loop;task api:test:coverage/task code-analysis:phpstan→ directdocker compose execcalls (coverage still viaXDEBUG_MODE=coverage … --coverage-clover).The Taskfile targets stay for local development; only CI stops calling them.
Verification
Ran the exact inlined commands locally: fixtures load for all 7 indexes,
phpunit --coverage-clover→ 203 tests / 496 assertions + Clover report, phpstan level 8 clean, prettier clean.Note
Kept
actions/checkout@v5(version bumps are PR #39's scope) — expect a trivial reconcile against #39 on merge.api-spec.ymlstill uses Task (PR #40); converting it can follow the same pattern if wanted.