Skip to content

refactor(event): remove legacy IOCP backend - #890

Merged
ithewei merged 2 commits into
masterfrom
refactor/remove-iocp
Sep 25, 2026
Merged

ithewei merged 2 commits into
masterfrom
refactor/remove-iocp

Conversation

@ithewei

@ithewei ithewei commented Sep 25, 2026

Copy link
Copy Markdown
Owner

Summary

  • remove the unmaintained native EVENT_IOCP backend and overlapio implementation
  • remove IOCP-only state and conditional dispatch from the core event loop
  • document the maintained Windows backends: wepoll by default and WSAPoll when WITH_WEPOLL=OFF

The native IOCP path stopped being the Windows default in 2020 and had no supported build option. Windows continues to use the existing readiness-based NIO path through wepoll or WSAPoll.

Verification

  • cmake --build /private/tmp/libhv-remove-iocp-build-20260926 --parallel
  • cmake --build /private/tmp/libhv-remove-iocp-tests-20260926 --target unittest --parallel
  • make unittest
  • bash scripts/unittest.sh
  • MinGW cross-build with WITH_WEPOLL=ON
  • MinGW cross-build with WITH_WEPOLL=OFF
  • repository scan confirms no remaining EVENT_IOCP, overlapio, or event/iocp.c references outside the local implementation plan

Co-authored-by: TRAE CLI <traecli@bytedance.com>
Copilot AI lite review requested due to automatic review settings September 25, 2026 16:44

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

Co-authored-by: TRAE CLI <traecli@bytedance.com>
Copilot AI review requested due to automatic review settings September 25, 2026 16:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@ithewei
ithewei merged commit 62f1292 into master Sep 25, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants