Skip to content

Require imas_data_dictionaries >= 4.1.0 - #151

Merged
olivhoenen merged 1 commit into
iterorganization:developfrom
Shakhtar-Sankur:dd-min-version
Nov 17, 2026
Merged

olivhoenen merged 1 commit into
iterorganization:developfrom
Shakhtar-Sankur:dd-min-version

Conversation

@Shakhtar-Sankur

Copy link
Copy Markdown
Contributor

Fixes #142

As suggested in #142, this declares in pyproject.toml the minimum imas_data_dictionaries version the code and tests rely on. Tests such as test_convert_core_edge_plasma.py create IDSs with IDSFactory("4.1.0"), but imas_data_dictionaries 4.0.0 does not ship DD 4.1.0, so with the current unpinned dependency they fail:

$ pip install '.[test]' 'imas_data_dictionaries==4.0.0'
$ python -c "import imas_data_dictionaries as d; print('4.1.0' in d.dd_xml_versions())"
False
$ pytest imas/test/test_convert_core_edge_plasma.py
FAILED imas/test/test_convert_core_edge_plasma.py::test_convert_training_core_profiles
FAILED imas/test/test_convert_core_edge_plasma.py::test_convert_missing_qty
...
8 failed

With "imas_data_dictionaries>=4.1.0":

  • asking for imas_data_dictionaries==4.0.0 together with IMAS-Python is refused by the resolver, instead of installing a combination that cannot run the tests;
  • a plain pip install .[test] picks up 4.1.1, and test_convert_core_edge_plasma.py passes: 8 passed;
  • the --mini test suite passes: 488 passed, 67 skipped.

Public run, develop and this branch side by side: https://www.kaggle.com/code/sankurkundu/notebook312a21559a

The tests (for example test_convert_core_edge_plasma.py) create IDSs
with IDSFactory("4.1.0"), which fails with imas_data_dictionaries 4.0.0
because that package does not ship DD 4.1.0. Declare the minimum version
in pyproject.toml so pip installs a dictionary package that has it.

Fixes iterorganization#142
@olivhoenen
olivhoenen merged commit 0e5ef4e into iterorganization:develop Nov 17, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Error when running imas python v2.3.0 with DDv4.0.0

2 participants