Add units metadata to Identifiers#131
Merged
olivhoenen merged 1 commit intoJun 12, 2026
Merged
Conversation
N.B. This commit also includes a refactor to remove IDSIdentifier.__init__ and use __new__ only. See https://docs.python.org/3/howto/enum.html#when-to-use-new-vs-init
maarten-ic
requested review from
olivhoenen and
prasad-sawantdesai
as code owners
|
Will it support identifier |
Collaborator
Author
it will need another patch: I didn't build it yet because the DD PR is still open. |
olivhoenen
approved these changes
Jun 12, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
N.B. This PR also includes a refactor to remove
IDSIdentifier.__init__and use__new__only. See https://docs.python.org/3/howto/enum.html#when-to-use-new-vs-initRequested by @jwasikpsnc for IBEX.