Use UInt32Value for min_cluster_size to fix client-go JSON apply - #3754
Use UInt32Value for min_cluster_size to fix client-go JSON apply#3754sayap wants to merge 1 commit into
Conversation
UInt64Value serializes as a JSON string (proto3 JSON spec) but the DestinationRule CRD schema declares minClusterSize as type: integer, so DRs containing it are rejected by the API server when applied via client-go, while kubectl apply works because it bypasses protobuf marshaling. UInt32Value serializes as a JSON number, matching the schema. A host count with a default of 6 does not require uint64 range.
|
🤔 🐛 You appear to be fixing a bug in Go code, yet your PR doesn't include updates to any test files. Did you forget to add a test? Courtesy of your friendly test nag. |
|
😊 Welcome @sayap! This is either your first contribution to the Istio api repo, or it's been You can learn more about the Istio working groups, Code of Conduct, and contribution guidelines Thanks for contributing! Courtesy of your friendly welcome wagon. |
istio-testing
added
size/XS
|
Hi @sayap. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
1 similar comment
|
Hi @sayap. Thanks for your PR. I'm waiting for a istio member to verify that this patch is reasonable to test. If it is, they should reply with Regular contributors should join the org to skip this step. Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
This will require a follow-up change in istio/istio, to change the type and also map back to UInt64Value in Envoy. |
3 participants
UInt64Value serializes as a JSON string (proto3 JSON spec) but the DestinationRule CRD schema declares minClusterSize as type: integer, so DRs containing it are rejected by the API server when applied via client-go, while kubectl apply works because it bypasses protobuf marshaling. UInt32Value serializes as a JSON number, matching the schema. A host count with a default of 6 does not require uint64 range.