lb: add new backend utililization lb policy - #3750
Open
wbpcode wants to merge 3 commits into
Open
Conversation
Signed-off-by: wbpcode <wbphub@gmail.com>
istio-testing
added
the
size/M
Contributor
Author
Signed-off-by: wbpcode <wbphub@gmail.com>
Signed-off-by: wbpcode <wbphub@gmail.com>
| uint64 minimum_ring_size = 4 [deprecated = true]; | ||
| } | ||
|
|
||
| // Client-side weighted round-robin load balancing policy that uses |
Contributor
There was a problem hiding this comment.
nit: s/Client-side weighted round-robin/BackendUtilizationLB
| // same weight as endpoints without metrics. | ||
| // Default is 10s. | ||
| // +protoc-gen-crd:duration-validation:none | ||
| google.protobuf.Duration blackout_period = 1; |
Contributor
There was a problem hiding this comment.
Should we call weight_stabilization_period?
| // standard `application_utilization` metric is not available from the | ||
| // backend. When set, these metrics are used in the weight formula | ||
| // instead of the default. | ||
| repeated string metric_names_for_computing_utilization = 5; |
Contributor
There was a problem hiding this comment.
There is some other logic to this than just using these inplace of defaults right? https://github.com/envoyproxy/envoy/blob/b5137693d49c079ff50d2e3b7cbd539a78fe863d/api/envoy/extensions/load_balancing_policies/client_side_weighted_round_robin/v3/client_side_weighted_round_robin.proto#L94
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR added new API for backend utilization policy. See istio/istio#60814 for more detail