Address Responsive Design review comments#48
Draft
issackjohn wants to merge 14 commits intoresponsive-designfrom
Draft
Address Responsive Design review comments#48issackjohn wants to merge 14 commits intoresponsive-designfrom
issackjohn wants to merge 14 commits intoresponsive-designfrom
Conversation
* Write dev files to different location. * Using root code style. * Remove unused Prettier and ESLint configuration files from responsive design directory * Update scrollIntoView method to accept options parameter for better control * change scroll behavior to instant * Refactor Responsive-Design tests to use async functions * Rename output directory from dev-dist to build-dev in configuration files * Re-install resize observer
* Refactor iteration methods to use for...of loops * add matchMedia support * build dist
* add disconnectedCallback * Move to connectedCallback
Properly capturing layout work in steps ReduceWidthIn5Steps and IncreaseWidthIn5Steps.
* Refactor layout method to accept target element for improved flexibility * refactor: simplify layout method by using logical OR for body assignment * refactor: replace magic numbers with named constants for media query breakpoints * refactor: replace repeated calls to getContentDocument with a variable for improved readability
* Remove iframe and integrate cooking-app directly into index.html * Remove querySelectorAllInShadowRoot method from PageElement class * move setWidth method to Page class
* remove extra changes * Add content visibility change handlers for video grid
issackjohn
force-pushed
the
responsive-design
branch
2 times, most recently
from
eed2854 to
0f2abd2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses unresolved Responsive Design PR 453 review feedback.
ResizeObservercallback and entry counts so resize-step behavior can be compared across browsers.content-visibility: autoand documents why the workload intentionally exercises it.Validation:
npm run formatnpm run lint:checknpm run buildinexperimental\responsive-designgit diff --checkNote: A targeted local browser run could not start because this environment could not obtain an Edge WebDriver, so browser validation is left to PR CI.