Address IndexedDB deletion review comments#47
Closed
issackjohn wants to merge 3 commits intoissackjohn-WCIndexeddbfrom
Closed
Address IndexedDB deletion review comments#47issackjohn wants to merge 3 commits intoissackjohn-WCIndexeddbfrom
issackjohn wants to merge 3 commits intoissackjohn-WCIndexeddbfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This narrows the IndexedDB review-fix PR to the concrete review comment about avoiding resolver state on a function.
iterationFinishedListener.promiseResolvepattern with a localwaitForPreviousPageLoaded()helper that registers a one-shot listener.FinishDeletingItemsFromDBignored step, so delete DB write completion is still measured the same way as before this PR.dist/copy to matchsrc/.Follow-up
The WebKit review comment about delete/read DB synchronization sounded speculative (
might have to sync the DB). That would change what the delete benchmark measures, so this PR leaves it out and treats it as follow-up benchmark-semantics work.Validation
npm run buildinexperimental/javascript-wc-indexeddbnpx --no-install eslint ./experimental/javascript-wc-indexeddb/src/workload-test.mjs ./experimental/javascript-wc-indexeddb/src/storage/base-storage-manager.js ./experimental/javascript-wc-indexeddb/src/storage/dexieDB-manager.js ./experimental/javascript-wc-indexeddb/src/storage/indexedDB-manager.jsgit diff --check