Skip to content

Add neil.json for domain configuration#35780

Closed
neilwilliam wants to merge 3 commits intois-a-dev:mainfrom
neilwilliam:patch-1
Closed

Add neil.json for domain configuration#35780
neilwilliam wants to merge 3 commits intois-a-dev:mainfrom
neilwilliam:patch-1

Conversation

@neilwilliam
Copy link
Copy Markdown
Contributor

Requirements

  • [x ] I agree to the Terms of Service.
  • [x ] My file is following the domain structure.
  • [x ] My website is reachable and completed.
  • [ x] My website is software development related.
  • [x ] My website is not for commercial use.
  • [x ] I have provided contact information in the owner key.
  • [ x] I have provided a preview of my website below.

Website Preview

https://neilssites.web.app
image

@neilwilliam neilwilliam requested a review from a team as a code owner April 3, 2026 19:42
Copilot AI review requested due to automatic review settings April 3, 2026 19:42
@is-a-dev-reviewbot
Copy link
Copy Markdown

Hi there! 👋

You've successfully made a pull request! Here are some steps to do while waiting for a maintainer to review the pull request:

  1. Check if the filename, file format, and records are valid. If you don't know if it's valid, please read this part of the documentation and use a JSON validator/formatter, like jsonlint. Make sure that the file is in the domains directory and not somewhere else in the repository.
  2. Please make sure that you've filled out the pull request template. It is generally not a good idea to overwrite the pull request template with something else unless you know what you are doing. Make sure to add either a publicly available preview of your website or a screenshot of it.
  3. Please wait patiently. Pull requests may take between a couple hours to 3 days. All of the maintainer team are volunteers and try to review the pull requests in their spare time. If you want a chance of getting your pull request merged faster then send your pull request number once in the #pull-requests channel in our Discord server and wait patiently.
  4. Please note that mentioning maintainers in pull requests without it being reviewed could lead to you getting marked as "low priority"; this also applies to pinging the maintainers in the Discord server or messaging the maintainers in private to review the pull request.

Note: Because of the influx of pull requests we are trying to do them all, but this would mean longer wait time. We'll try to get to them when we can. Thanks for the patience.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Adds a new domain configuration file for the neil subdomain in the is-a.dev registry.

Changes:

  • Introduces domains/neil.json with owner metadata and a CNAME record to neilssites.web.app.
  • Sets proxied to false for the domain.

Copilot AI review requested due to automatic review settings April 4, 2026 06:43
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 1 out of 1 changed files in this pull request and generated 2 comments.

"discord": "neillobo"
},
"records": {
"CNAME": "neilssites.web.app"
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

records object is invalid JSON: missing a comma after the CNAME entry, so this file will fail JSON parsing/tests.

Suggested change
"CNAME": "neilssites.web.app"
"CNAME": "neilssites.web.app",

Copilot uses AI. Check for mistakes.
Comment on lines +9 to +10
"A": ["104.18.4.103", "104.18.5.103"],
"AAAA": ["2606:4700::6812:467", "2606:4700::6812:567"]
Copy link

Copilot AI Apr 4, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This configuration defines CNAME alongside A/AAAA for the same subdomain. A hostname cannot have a CNAME/ALIAS record at the same time as other address records; Cloudflare will reject or behave unpredictably. Choose either CNAME (typical for Firebase) or A/AAAA, but not both.

Suggested change
"A": ["104.18.4.103", "104.18.5.103"],
"AAAA": ["2606:4700::6812:467", "2606:4700::6812:567"]

Copilot uses AI. Check for mistakes.
@STICKnoLOGIC
Copy link
Copy Markdown
Member

due to high surge/influx of PRs, we will automatically close PRs that failed the CI test result, kindly check, read, follow and understand our curated guide -> https://docs.is-a.dev

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants