Update setup instructions#437
Conversation
c9377d6 to
6972a4d
Compare
felix-kaestner
left a comment
There was a problem hiding this comment.
As for naming suggestions, I could think of "setup" as you already named the branch and PR that way. So I think that would be quite intuitive. But also no strong opinion here.
Add prerequisites into README. I'm just listing the packages and not including exact shell commands, as these will differ per OS and package manager Add a new `make setup` target that wraps all `make` targets that install dependencies Signed-off-by: Adam Trizuljak <adam.trizuljak@sap.com>
6972a4d to
eb1d94c
Compare
|
IMO I will remove all "install-*" command and define list of required tool in README. It should be up to user how to install those tools (brew, macports, nix, apt, snap, source, ...) and on what machine (this does not work on fresh VM with ubuntu). |
On that note, #397 might be a welcome change because it follows the kubebuilder convention of installing required tooling local within the project only (not system-wide) into a At the same time, this eliminates the problems of different people having different versions of the same tool installed on their machine, leading to differences in e.g. code generation or formatting, as the versions used by this repo would be pinned. |
I am updating the setup instructions based on my recent experience with installing the dev environment on MacOS.
preparesetuptarget that wraps allmaketargets that install dependencies.Suggestions for a better name are welcome:)