e2e-tests (1/4): Repackage gnmi-test-server and e2e test infrastructure#407
Open
nikatza wants to merge 1 commit into
Open
e2e-tests (1/4): Repackage gnmi-test-server and e2e test infrastructure#407nikatza wants to merge 1 commit into
e2e test infrastructure#407nikatza wants to merge 1 commit into
Conversation
nikatza
force-pushed
the
refactor-tests-1
branch
from
d6f35e8 to
4f9dd88
Compare
nikatza
force-pushed
the
refactor-tests-1
branch
from
4f9dd88 to
23777e1
Compare
nikatza
changed the title
e2e test infrastructuree2e test infrastructure
nikatza
force-pushed
the
refactor-tests-1
branch
7 times, most recently
from
791563e to
090c7f3
Compare
nikatza
force-pushed
the
refactor-tests-1
branch
19 times, most recently
from
3a120c9 to
831bed7
Compare
nikatza
force-pushed
the
refactor-tests-1
branch
4 times, most recently
from
7da7ea8 to
7ecb0d8
Compare
nikatza
force-pushed
the
refactor-tests-1
branch
2 times, most recently
from
57d07be to
774afd2
Compare
nikatza
force-pushed
the
refactor-tests-1
branch
4 times, most recently
from
9fc2d6b to
d6c4f76
Compare
nikatza
force-pushed
the
refactor-tests-1
branch
6 times, most recently
from
302bbc3 to
96a6617
Compare
nikatza
force-pushed
the
refactor-tests-1
branch
from
96a6617 to
c9b5a8f
Compare
e2e tests should only evaluate the correct deployment of the operator as defined by the kubebuilder markers. Hence, in this commit we remove all the gNMI related infrastructure from the e2e tests. The current integration tests with the gNMI test server will be later moved into its own space within the project. The tests will use an `envtest` environment, removing the need to deploy a cluster to evaluate that the workflow from k8s resource to provider payload is correctly implemented. Hence, no need to have it as a module.The standalone main.go and Dockerfile are removed. We relocate the txtar test fixtures from test/e2e/testdata/ to test/gnmi/testdata/, where the gNMI integration tests will live. The default profile in kustomize now has prometheus enabled by default. With this change we can eliminate some code and remove the Makefile targets that modify the profile when running the e2e tests. Allow overriding the Prometheus Operator and cert-manager installation URLs via environment variables PROMETHEUS_OPERATOR_URL and CERT_MANAGER_URL. Signed-off-by: Pujol <enric.pujol@sap.com>
nikatza
force-pushed
the
refactor-tests-1
branch
from
c9b5a8f to
6c3f4a6
Compare
Merging this branch will not change overall coverage
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
e2e tests should only evaluate the correct deployment of the operator as defined by the kubebuilder markers. Hence, we remove all the gNMI related infrastructure from the e2e tests.
This PR effectively removes the current tests which are to be reincorporated in a follow-up PR