Link to first compilation issue line in GitHub Actions#19
Merged
Conversation
The generated GitHub Actions step links always used #step:N:1, pointing to the first line of the step. Now the link points to the line where the first warning (or error) actually occurred in the compilation output. https://claude.ai/code/session_01Eph17CQCfdnKaJhA2nSr9W
yaito3014
temporarily deployed
to
CppWarningNotifier
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
The build step was using >> to redirect all output to compilation.log, hiding it from the step log. Since step links now point to the specific warning line, the output must be visible in the step log. Using tee sends output to both the file and stdout. https://claude.ai/code/session_01Eph17CQCfdnKaJhA2nSr9W
yaito3014
temporarily deployed
to
CppWarningNotifier
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
Each regex was duplicated: once for the whole-string check and once for findIndex. Now we just do findIndex directly — if it finds a match, we know both the result and the line number in one pass. https://claude.ai/code/session_01Eph17CQCfdnKaJhA2nSr9W
yaito3014
temporarily deployed
to
CppWarningNotifier
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
yaito3014
temporarily deployed
to
CppWarningNotifier
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
Add console.log statements to trace warning/error detection (total lines, matched index, matched content, final result). Apply a +3 line offset to firstIssueLine to account for GitHub Actions preamble lines in step logs. https://claude.ai/code/session_01Eph17CQCfdnKaJhA2nSr9W
yaito3014
temporarily deployed
to
CppWarningNotifier
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
yaito3014
had a problem deploying
to
CppWarningNotifier
GitHub Actions
Failure
yaito3014
had a problem deploying
to
CppWarningNotifier
GitHub Actions
Failure
yaito3014
had a problem deploying
to
CppWarningNotifier
GitHub Actions
Failure
yaito3014
had a problem deploying
to
CppWarningNotifier
GitHub Actions
Failure
yaito3014
had a problem deploying
to
CppWarningNotifier
GitHub Actions
Failure
yaito3014
had a problem deploying
to
CppWarningNotifier
GitHub Actions
Failure
yaito3014
temporarily deployed
to
CppWarningNotifier
GitHub Actions
Inactive
This comment has been minimized.
This comment has been minimized.
yaito3014
temporarily deployed
to
CppWarningNotifier
GitHub Actions
Inactive
Member
Author
|
fixed #17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Updated the GitHub Actions job link generation to point directly to the first line where a compilation warning or error occurs, rather than always linking to line 1.
Key Changes
findIndex()to locate the first occurrence of a warning or error patternfirstIssueLineinstead of hardcoded1Implementation Details
idx !== -1check)https://claude.ai/code/session_01Eph17CQCfdnKaJhA2nSr9W