Merged
Conversation
Replace Map<string, Row> with Map<string, Map<string, Row>> so the cell lookup uses a (rowKey, column) pair instead of serializing both parts into a single JSON string. This eliminates the double JSON.stringify and makes the key structure explicit. https://claude.ai/code/session_011phn9pZy35XcjPTkM7eRLb
- Replace non-null assertions on env vars with a requireEnv() helper that throws descriptive errors on missing variables - Validate regex named groups (runId/jobId) before destructuring - Make post_comment async and await it at both call sites - Extract duplicated row key generation into generateRowKey() helper - Replace IIFEs for compileResult and stepId with plain control flow (stepId now uses Array.findIndex instead of manual while loop) - Change ROW_HEADER_FIELDS type from any[] to string[] https://claude.ai/code/session_011phn9pZy35XcjPTkM7eRLb
Introduce a CompositeKeyMap<V> class that encapsulates JSON.stringify behind a typed get/set API with readonly string[] keys. This flattens the previous Map<string, Map<string, Row>> into a single map keyed by [...rowFieldValues, column], removing the generateRowKey helper and the manual nested-map bookkeeping in generateTable. https://claude.ai/code/session_011phn9pZy35XcjPTkM7eRLb
Drop the accumulator parameter (a C++ value-semantics pattern) and let each recursive call return its own array, spread into the parent. Also inlines the two-pass dir collection into a single loop. https://claude.ai/code/session_011phn9pZy35XcjPTkM7eRLb
Makes the required fields explicit while keeping the index signature for dynamic regex group fields. https://claude.ai/code/session_011phn9pZy35XcjPTkM7eRLb
- Remove unreachable .length === 0 checks after null checks on String.match() results (always returns null or non-empty array) - Fix compareDate using == (reference equality) on Date objects; use .getTime() subtraction instead - Use === instead of == for string comparison - Change rows to const (never reassigned, only mutated) https://claude.ai/code/session_011phn9pZy35XcjPTkM7eRLb
yaito3014
temporarily deployed
to
CppWarningNotifier
GitHub Actions
Inactive
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.