Skip to content

Make OSPFv3 validation helpers VRF aware#3520

Open
jbemmel wants to merge 4 commits into
ipspace:devfrom
jbemmel:bugfix/vlan-vrf-lite-ipv6
Open

Make OSPFv3 validation helpers VRF aware#3520
jbemmel wants to merge 4 commits into
ipspace:devfrom
jbemmel:bugfix/vlan-vrf-lite-ipv6

Conversation

@jbemmel

@jbemmel jbemmel commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

Change the VLAN VRF lite test to use dual-stack ipv4/ipv6 so we test both combinations

ipspace added a commit that referenced this pull request Jun 24, 2026
@ipspace
Fix: Use full template path when including FRR GR config
663ea66 
OSPF GR was implemented with an included template on FRR. The path to
that template is not available when the OSPF config is invoked from a
VRF template.

Based on #3520 by @jbemmel
@ipspace

ipspace commented Jun 24, 2026

Copy link
Copy Markdown
Owner

Thanks for the fix, but you (yet again) mixed unrelated things into the same PR:

  • The template bug is really bad. I cherry-picked those changes into 'dev' branch, so when you'll rebase this one, you'll have a single-topic PR.
  • I agree that it would be nice to have VRF-aware OSPFv3 plugin tests (but that should be a standalone PR, which is now this PR ;)
  • Finally, what's wrong with adding IPv6 AF to the existing VRF+VLAN test? I don't care much about the device(s) that will fail to pass that test because the vendor decided in their infinite wisdom not to support OSPFv3 or VRF-aware OSPFv3.

jbemmel and others added 2 commits June 24, 2026 13:09
@jbemmel @cursoragent
Fix: Validate FRR OSPF neighbors in VRFs
ce73d28 
Use VRF-scoped FRR OSPF/OSPFv3 show commands and add an IPv6 VLAN VRF-lite test covering OSPFv3 over trunks.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jbemmel @cursoragent
Fix: Clean up FRR OSPF validation helpers
001b164 
Remove stale validator code and avoid unnecessary f-strings in static FRR OSPF commands.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jbemmel jbemmel marked this pull request as draft June 24, 2026 18:09
@jbemmel jbemmel force-pushed the bugfix/vlan-vrf-lite-ipv6 branch from 317167e to 001b164 Compare June 24, 2026 18:09
@jbemmel @cursoragent
Fix: Merge VLAN VRF-lite IPv6 test
0ff7159 
Fold the IPv6 OSPFv3 VLAN VRF-lite coverage into the existing test case and remove the duplicate numbered topology.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jbemmel jbemmel changed the title Bugfix: Fix FRR template include path for OSPF (when used in VRF context) and make OSPFv3 validation helpers VRF aware Make OSPFv3 validation helpers VRF aware Jun 24, 2026
@jbemmel @cursoragent
Fix: Add OSPFv2 checks to VLAN VRF-lite test
15caa94 
Validate IPv4 OSPFv2 adjacency and reachability alongside the existing IPv6 OSPFv3 VLAN VRF-lite coverage.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jbemmel jbemmel marked this pull request as ready for review June 24, 2026 18:17
@jbemmel

jbemmel commented Jun 24, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

Change from single topic "issues I hit when adding vlan vrf ipv6 test" to just the ospfv3 validation helpers and the modified dual-stack test that uses them

ipspace
ipspace approved these changes Jun 26, 2026
View reviewed changes

@ipspace ipspace left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me ;) Will run the OSPFv2/OSPFv3 integration tests just to be on the safe side and merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ipspace ipspace ipspace approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jbemmel @ipspace