Merged
Conversation
max-ipinfo
approved these changes
Sep 3, 2025
silvanocerza
deleted the
silvano/eng-296-add-lite-api-support-to-ipinfospring
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Similar approach to other libraries. I added
IPinfoLiteSpringthat work in the same way ofIPinfoSpring, the only difference is that it usesIPinfoLiteinternally instead ofIPinfo.I also bumped the dependencies versions and added tests for both middlewares.
I had to add some methods to the
AttributeStrategyinterface sinceIPinfoandIPinfoLitereturn different types of response, I'm not sure this is the best approach but it's the fastest to implement. In hindisight I should have probably madeIPResponseandIPResponseLiteinherit from the same interface or class, that way I could have used generics inAttributeStrategy.