Merged
Conversation
aschmahmann
force-pushed
the
feat/increase-routing-limits
branch
from
36fbef7 to
adc6960
Compare
lidel
reviewed
Sep 3, 2024
hsanjuan
force-pushed
the
feat/increase-routing-limits
branch
from
0693583 to
2ebfc5b
Compare
Contributor
|
This is ready for testing I think |
Contributor
|
I am seeing |
gammazero
reviewed
Nov 27, 2024
gammazero
approved these changes
Nov 27, 2024
gammazero
approved these changes
Nov 29, 2024
hsanjuan
removed
the
status/blocked
gammazero
reviewed
Nov 30, 2024
| if err != nil { | ||
| panic(err) | ||
| } | ||
| pqm.Startup() |
Contributor
There was a problem hiding this comment.
Unless there is a need to start at some later time, or some modes of operation need a ProviderQueryQanager that has not been started, then I think New should also perform the startup.
Contributor
There was a problem hiding this comment.
Doing so prevents problems where calling Startup is missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This builds off of ipfs/boxo#641 and at the moment has two notable changes from the current setup:
Without some experimentation it's hard to tell what these numbers should be or what other sorts of heuristics we might want to use here. I don't think the ones we have are optimal, but for now figured we'd see if mostly tweaking the numbers helps at all. It's also not clear that we'd want both DHT and IPNI lookups to be rate-limited in the same way and right now they're joined together.
We should try this out on a staging branch and see what the impact looks like.