Move providing responsabilities from bitswap to blockservice#677
Closed
Move providing responsabilities from bitswap to blockservice#677
Conversation
Codecov ReportAttention: Patch coverage is
@@ Coverage Diff @@
## main #677 +/- ##
==========================================
- Coverage 60.36% 60.17% -0.20%
==========================================
Files 243 244 +1
Lines 30953 30867 -86
==========================================
- Hits 18684 18573 -111
- Misses 10612 10626 +14
- Partials 1657 1668 +11
|
Contributor
Author
|
Needs kubo PR to test |
Contributor
|
Reviewing this and probably merging into #641 ... |
hsanjuan
reviewed
Nov 18, 2024
Comment on lines
-143
to
-148
| ses := grabSessionFromContext(ctx, bs) | ||
| if ses != nil { | ||
| return ses | ||
| } | ||
|
|
||
| return newSession(ctx, bs) |
Contributor
There was a problem hiding this comment.
I'm not sure why session-grabbing from context is removed... I remember old discussions about embedding sessions in contexts etc. but not sure if used...
Contributor
|
This was more or less made part of #641 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces #534 by @Jorropo which was outdated enough to make merging difficult.