blockservice: optimize getBlocks filter by not rescanning the already valid leading elements#558
Merged
1 commit merged intomainfrom Jan 15, 2024
Merged
blockservice: optimize getBlocks filter by not rescanning the already valid leading elements#5581 commit merged intomainfrom
1 commit merged intomainfrom
Conversation
… valid leading elements We would scan the valid leading elements twice.
Contributor
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Jan 15, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
@@ Coverage Diff @@
## main #558 +/- ##
==========================================
- Coverage 65.45% 65.45% -0.01%
==========================================
Files 207 207
Lines 25622 25623 +1
==========================================
Hits 16772 16772
- Misses 7369 7371 +2
+ Partials 1481 1480 -1
|
This was referenced Jan 15, 2024
Closed
hacdias
approved these changes
Jan 15, 2024
This was referenced Jan 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

We would scan the valid leading elements twice.