Merged
Conversation
The IPData API returns the `count` field as a JSON string, but the model expected System.Int32. Add IntJsonConverter to handle both string and number JSON tokens for the Count property. https://claude.ai/code/session_01V2uek6e28i6ARom7qVt1Mz
The API returns the count field as a JSON string instead of a number, causing JsonException on Lookup(), BulkLookup(), and Lookup(culture). Added test cases for both string and numeric count values, and updated the test fixture to include count as a string matching real API behavior. https://claude.ai/code/session_01V2uek6e28i6ARom7qVt1Mz
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.