⚡ Bolt: [performance improvement] Optimize handleAgentEvents complexity#154
⚡ Bolt: [performance improvement] Optimize handleAgentEvents complexity#154iotserver24 wants to merge 2 commits into
Conversation
Extracts array index searching outside the event batch loop in handleAgentEvents, reducing complexity from O(N*M) to O(N+M) and reducing main thread UI blocking during long streams. Also fixes dropped tool_call events by queueing indices.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Plus Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Extracts array index searching outside the event batch loop in handleAgentEvents, reducing complexity from O(N*M) to O(N+M) and reducing main thread UI blocking during long streams. Also fixes dropped tool_call events by queueing indices. Resolves CI audit failures.
|
Hey @iotserver24! 👋 I'll go through the changes and help you out with an automated review! 🔍 Starting the review now... |
💡 What: Extracts target index searching (
lastAssistantIndex,pendingToolIndices) outside the batch loop insidehandleAgentEvents.🎯 Why: Previously, finding the target message inside the batch loop created an O(N*M) complexity (where N is the chat history length and M is the batch size). For large conversations or streaming bodies, this blocked the React main thread, causing severe UI lag.
📊 Impact: Reduces time complexity to O(N+M), practically removing scaling slowdowns during heavy token streaming. Also fixes a subtle bug where simultaneous
tool_callandtool_resultevents were mishandled by using an array queue instead of a singular tracked index.🔬 Measurement: Verified with
pnpm testandpnpm lint. Playwright screenshot confirms the app UI renders messages flawlessly with the updated state logic.PR created automatically by Jules for task 172685728171467853 started by @iotserver24