Skip to content

limit query range #4757

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −2
Open

limit query range #4757

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion api/config.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ var DefaultConfig = Config{
WebSocketPort: 16014,
TpsWindow: 10,
GasStation: gasstation.DefaultConfig,
RangeQueryLimit: 1000,
RangeQueryLimit: 2000,
BatchRequestLimit: _defaultBatchRequestLimit,
WebsocketRateLimit: 5,
ListenerLimit: 5000,
Expand Down
3 changes: 3 additions & 0 deletions api/coreservice.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1618,6 +1618,9 @@ func (core *coreService) LogsInRange(filter *logfilter.LogFilter, start, end, pa
if err != nil {
return nil, nil, err
}
if end > start+core.cfg.RangeQueryLimit {
return nil, nil, status.Error(codes.InvalidArgument, "range exceeds the limit")
}
// getLogs via range Blooom filter [start, end]
blockNumbers, err := core.bfIndexer.FilterBlocksInRange(filter, start, end, paginationSize)
if err != nil {
Expand Down
2 changes: 1 addition & 1 deletion api/coreservice_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -911,7 +911,7 @@ func TestActions(t *testing.T) {
},
)

_, err := cs.Actions(0, 1001)
_, err := cs.Actions(0, 2001)
require.ErrorContains(err, "range exceeds the limit")
})

Expand Down