This repository was archived by the owner on May 4, 2022. It is now read-only.
Enable dragcontent to be right or left to handle RTL side menu support#315
Open
peterWilson34 wants to merge 1 commit intoionic-team:masterfrom
Open
Enable dragcontent to be right or left to handle RTL side menu support#315peterWilson34 wants to merge 1 commit intoionic-team:masterfrom
peterWilson34 wants to merge 1 commit intoionic-team:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
On dynamic change of ion-side-menu
sideproperty to support RTL direction the menu is stopped working and need to reload the page to work again withrightdirection which is not a good practice for mobile UX.Changes proposed in this pull request:
drag-contentto berightorleft$watchto detect ifdrag-contentvalue changed at any point of timeIonic Version: 1.x
use case sample