This repository was archived by the owner on May 4, 2022. It is now read-only.
Added option to collection-repeat to use original scroll content size#216
Open
sinedied wants to merge 1 commit intoionic-team:masterfrom
Open
Added option to collection-repeat to use original scroll content size#216sinedied wants to merge 1 commit intoionic-team:masterfrom
sinedied wants to merge 1 commit intoionic-team:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Short description of what this resolves:
Combining the
collection-repeatdirective with the pull-to-search pattern cause issues as the scroll view size is forced to the list size and ignore the original scroll view content size.Changes proposed in this pull request:
This patch adds a
use-content-size="true"option to the directive to fix this behavior.When enabled, you can use css to apply a minimum width or height to the scroll view content, and it will be used instead of overriding it with the list size.
Ionic Version: 1.x
Fixes: https://forum.ionicframework.com/t/collection-repeat-and-pull-to-search/71603