Skip to content

fix(item-sliding): remove item-sliding-closing class and re-enable gesture when opening sliding item #31588

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
rudrakshagarwal4200-ai wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(item-sliding): remove item-sliding-closing class and re-enable gesture when opening sliding item #31588

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5e734fe
Handle open amount in item sliding component
rudrakshagarwal4200-ai Oct 16, 2026
abef2ff
Implement e2e test for item sliding options
rudrakshagarwal4200-ai Oct 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions core/src/components/item-sliding/item-sliding.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -422,6 +422,13 @@ export class ItemSliding implements ComponentInterface {
style.transition = '';
}

if (openAmount !== 0) {
el.classList.remove('item-sliding-closing');
if (this.gesture) {
this.gesture.enable(!this.disabled);
}
}

if (openAmount > 0) {
this.state =
openAmount >= this.optsWidthRightSide + SWIPE_MARGIN
Expand Down
16 changes: 16 additions & 0 deletions core/src/components/item-sliding/test/basic/item-sliding.e2e.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -262,5 +262,21 @@ configs({ modes: ['ios'], directions: ['ltr'] }).forEach(({ title, config }) =>

await openStartOptions(page, true);
});

test('opening opposite side should remove item-sliding-closing and keep options clickable', async ({ page }, testInfo) => {
testInfo.annotations.push({
type: 'issue',
description: 'https://github.com/ionic-team/ionic-framework/issues/29975',
});

const slidingItem = page.locator('#item2');
await slidingItem.evaluate(async (el: HTMLIonItemSlidingElement) => {
await el.open('end');
await el.open('start');
});
await page.waitForChanges();

await expect(slidingItem).not.toHaveClass(/item-sliding-closing/);
});
});
});
Loading