-
Notifications
You must be signed in to change notification settings - Fork 13.4k
feat(picker-legacy, picker-legacy-column): remove legacy components #31078
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: major-9.0
Are you sure you want to change the base?
Changes from all commits
6ad0b04
23a5dfc
0e334fb
b2bec97
70c09cb
d32937c
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -55,7 +55,6 @@ | |
| <ion-card-content> | ||
| <button class="expand" id="show-action-sheet" onclick="showActionSheet()">Show Action Sheet</button> | ||
| <button class="expand" id="show-menu" onclick="showMenu()">Show Menu</button> | ||
| <button class="expand" id="show-picker" onclick="showPicker()">Show Picker</button> | ||
| <button class="expand" id="show-toast" onclick="showToast()">Show Toast</button> | ||
| </ion-card-content> | ||
| </ion-card> | ||
|
|
@@ -115,26 +114,6 @@ | |
| await menu.open(); | ||
| } | ||
|
|
||
| async function showPicker() { | ||
|
Contributor
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This was not replaced by |
||
| const picker = Object.assign(document.createElement('ion-picker-legacy'), { | ||
| columns: [ | ||
| { | ||
| name: 'Picker', | ||
| selectedIndex: 2, | ||
| options: [ | ||
| { text: 'First' }, | ||
| { text: 'Second' }, | ||
| { text: 'Third' }, | ||
| { text: 'Fourth' }, | ||
| { text: 'Fifth' }, | ||
| ], | ||
| }, | ||
| ], | ||
| }); | ||
| document.body.appendChild(picker); | ||
| await picker.present(); | ||
| } | ||
|
|
||
| async function showToast() { | ||
| const toast = Object.assign(document.createElement('ion-toast'), { | ||
| message: 'Hello world!', | ||
|
|
||
This file was deleted.
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.