test(angular): validate checkbox and toggle in lazy template-form#31005
Open
OS-jacobbell wants to merge 3 commits intomainfrom
Open
test(angular): validate checkbox and toggle in lazy template-form#31005OS-jacobbell wants to merge 3 commits intomainfrom
OS-jacobbell wants to merge 3 commits intomainfrom
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
brandyscarney
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What is the current behavior?
Checkbox and toggle components are not validated to be ticked/on in
packages/angular/test/base/src/app/lazy/template-form. This prevents the error text from being displayed. While they have therequiredattribute, this only applies to accessibility for checkbox and toggle.What is the new behavior?
Does this introduce a breaking change?