Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue URL: internal
What is the current behavior?
Over 100 files, ~9,900 lines, are tracked but referenced by nothing on any branch. Most went dead years ago and survived because nothing reports an unreferenced file: it produces no conflict, no build error and no broken link.
What is the new behavior?
Deletes all 115.
Playgrounds (111 files). Four were re-added deliberately and eleven were left behind:
v7/v8/v9 range/basicandv7 datetime/themingcarry# TODO FW-4608. Ionic 7.1 renamed those playgrounds, which broke the JP build and blocked the release, so they were added back in June 2023 to be removed "once our translation infrastructure work is complete". jp now imports the renameddatetime/styling, so the need is gone, and the tracking ticket is Discarded and unassigned since May 2024.item/medialost its import on 09-22-2023 (docs(item): add best practices and usage guides #3123),item/theming/input-highlightandlabel/inputon 10-12-2023 (docs(many): remove legacy form control syntax from v7 playgrounds #3140), andtoast/swipe-gestureon 07-19-2024 (docs(api): use v8 demos instead of v7 demos for latest playgrounds #3759, which switched the latest pages to v8 demos).v8andv9copies were never referenced in any commit. The v8 cut (12-07-2023) and v9 cut (12-04-2025) both happened after the imports were removed, so each version snapshot copied an already-dead directory forward.v6 accordion/disable-grouppredates thedisable/grouprestructure and was never referenced.Dead data and config (4 files, 426 KB).
scripts/data/native.json, 281 KB, the retired Ionic Native plugin list, last meaningfully changed 09-09-2022scripts/data/github-commits.json, 144 KB, last changed 09-11-2019; its only reader,scripts/bak/build-data/file-contributors.ts, was deleted three days ago in chore(cleanup): remove unreferenced files and redirect ja developer-resource #4741.eslintrc.json, dead since 05-04-2023 (chore(lint): add prettier and lint on CI #2946), when prettier replaced eslint as the lint script and the eslint dependencies went with it. It still setsparser: @typescript-eslint/parser, which is not installed, so it cannot run.src/manifest.json, last touched 12-07-2021.src/is not served, so it is reachable at no URL, and its icon points at/docs/assets/, a path that has never existed.Does this introduce a breaking change?
Other information
Verified with a full build plus typecheck, tests and both generators, since
scripts/cli.mjsstill reads the two data files left in place.