fix(android): show only the requested system bar#8480
Open
fallintoplace wants to merge 2 commits into
Open
Conversation
theproducer
approved these changes
May 26, 2026
Contributor
theproducer
left a comment
theproducer
left a comment
There was a problem hiding this comment.
@fallintoplace Thanks for the unit tests as well!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SystemBars.show({ bar })is calledshow()mapping for the empty, status-bar, and navigation-bar casesWhy
The Android
hide()path already treatsStatusBarandNavigationBarseparately, butshow(StatusBar)was callingWindowInsetsCompat.Type.systemBars(), which also reveals the navigation bar.Fixes #8479.
Testing
JAVA_HOME=/opt/homebrew/opt/openjdk@21 ANDROID_HOME=/Users/hoangvu/Library/Android/sdk ANDROID_SDK_ROOT=/Users/hoangvu/Library/Android/sdk PATH=/opt/homebrew/opt/openjdk@21/bin:$PATH ./gradlew -p capacitor testDebugUnitTest --tests com.getcapacitor.plugin.SystemBarsTest