chore(plugin): move to project root #75
Conversation
andredestro
force-pushed
the
move-plugin
branch
from
6de0f3d to
05ca60d
Compare
markemer
left a comment
markemer
left a comment
There was a problem hiding this comment.
Builds, seems like the straighforward mv . .. that I expected.
| uses: ./.github/actions/prepare-example-app | ||
| - name: 'Build Android example app' | ||
| working-directory: ./packages/example-app-capacitor/android | ||
| working-directory: ./example-app-capacitor/android |
There was a problem hiding this comment.
Minor: the example-app-capacitor was labelled like such because at the time we were planning to have multiple example apps in the repo; now that it's no longer the case, I reckon just example-app is fine.
| - name: 'Check README.md changes' | ||
| working-directory: ./packages/capacitor-plugin | ||
| run: | | ||
| if ! cmp --silent README.md ../../README.md.original; then | ||
| echo "Detected README.md changes; Do 'npm run build' to update the docs." | ||
| exit 1 | ||
| fi No newline at end of file |
There was a problem hiding this comment.
This is technically still relevant, it's meant as a check to make sure npm run build was run so that docs are updated.
It's just that now instead of comparing README.md and ../../README.md.original, you'd compare README.md and README.md.original
There was a problem hiding this comment.
These are lint changes? If so, it's probably simpler to just tell linter(s) to ignore the example app I think, as I think we have in other repos - e.g. eslint config for inappbrowser
No description provided.