align chooseFromGallery with new API#12
Merged
OS-ruimoreiramendes merged 2 commits intofeat/RMET-4099/camera-unificationfrom Mar 20, 2026
Merged
Conversation
OS-ruimoreiramendes
requested review from
OS-pedrogustavobilro and
alexgerardojacinto
OS-pedrogustavobilro
approved these changes
Mar 20, 2026
Contributor
OS-pedrogustavobilro
left a comment
OS-pedrogustavobilro
left a comment
There was a problem hiding this comment.
I left a comment, but I guess it's ok to merge this one and then I'll fix in the other PR.
Comment on lines
+191
to
+192
| width = call.getInt("width") ?: 0, | ||
| height = call.getInt("height") ?: 0, |
Contributor
There was a problem hiding this comment.
Depending on which PR gets merged first, this or #11, there may be conflicts to resolve, as the name changed to targetWidth/targetHeight.
alexgerardojacinto
approved these changes
Mar 20, 2026
OS-ruimoreiramendes
merged commit ddcc235
into
feat/RMET-4099/camera-unification
5 of 6 checks passed
OS-ruimoreiramendes
deleted the
feat/RMET-4099/chooseFromGallery-new-api
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Change Type
Rationale / Problems Fixed
Tests or Reproductions
Screenshots / Media
Platforms Affected
Notes / Comments